Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icon to adhere to standard macOS look. #9701

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix icon to adhere to standard macOS look. #9701

merged 1 commit into from
Dec 9, 2022

Conversation

jmacato
Copy link
Contributor

@jmacato jmacato commented Dec 6, 2022

@soosr
Copy link
Collaborator

soosr commented Dec 7, 2022

This should be in the release.

The PR also changes the icon that had no problem with margins:
image

Please revert the changes on WalletWasabi.Fluent/Assets/WasabiLogo.ico, I don't think that is necessary.

soosr
soosr approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@wieslawsoltes wieslawsoltes merged commit b872dc2 into WalletWasabi:master Dec 9, 2022
@Pule08 Pule08 mentioned this pull request Dec 12, 2022
Closed
@yahiheb yahiheb mentioned this pull request Dec 25, 2022
Closed
@jmacato jmacato deleted the vdg/fix-app-icons branch January 9, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wieslawsoltes wieslawsoltes wieslawsoltes approved these changes

@soosr soosr soosr approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmacato @soosr @wieslawsoltes