Remove backward compatibility code #9704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
changed the title
yahiheb
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes code that ensures backward compatibility. I'm aware that the policy is not to break BC but there are some considerations that might make it reasonably in this case.
So 2 years is a long time and there were many new WW1 versions after that. So the removed code is only useful for people who are on a very old WW1 versions and did not upgrade to the latest WW1 also did not install WW2 and also did not need Trezor T hotfix, probably use an oldish Tor version, etc. Moreover, .NET Core 3.1 reaches EOF in a week.
So overall, maybe there is an old software collector who is running her old WW version but it's pretty unlikely. Adding a release note that if you are on a very old WW1 client, you need to upgrade to the current released WW2 build first and then to the latest WW2 version covers even those potentially affected.
Is there anything I'm missing?
btw: We don't need to merge this now. We can say that we'll warn users for the next 1 or 2 releases and then merge this PR. An alternative is to have the code there forever, I don't find sufficient reason for it and also it's not a common software practice.