Extract round related actions to method #9705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Szpoti
previously approved these changes
Dec 7, 2022
yahiheb
requested changes
Dec 8, 2022
|
@kiminuo @adamPetho can you take a quick look at this? |
kiminuo
reviewed
Dec 8, 2022
kiminuo
reviewed
Dec 8, 2022
kiminuo
reviewed
Dec 8, 2022
kiminuo
reviewed
Dec 8, 2022
kiminuo
reviewed
Dec 8, 2022
kiminuo
reviewed
Dec 8, 2022
kiminuo
reviewed
Dec 8, 2022
kiminuo
reviewed
Dec 8, 2022
| @@ -234,16 +232,50 @@ public async Task<CoinJoinResult> StartRoundAsync(IEnumerable<SmartCoin> smartCo | |||
| _ => throw new ArgumentOutOfRangeException() | |||
| }; | |||
| roundState.LogInfo(msg); | |||
There was a problem hiding this comment.
So if ProceedWithRoundAsync throws an exception that is caught by catch (UnexpectedRoundPhaseException ex) when (ex.Actual == Phase.Ended), then here we can still log that the round finished with broadcasting a transaction, right?
There was a problem hiding this comment.
Whatever the coordinator indicates with EndRoundState.
adamPetho
previously approved these changes
Dec 8, 2022
Co-authored-by: Kimi <58662979+kiminuo@users.noreply.github.com>
…into extractround
|
LGTM now |
|
Tested this during the night. It works reliably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for this #9681
Just moving the code and a small restructure.