macOS - sleep inhibiting II #9707
Conversation
* It test a Windows method we don't use. * The test did not discover any issue on macOS.
kiminuo
force-pushed
the
feature/2022-12-07-macOS-sleep-follow-up
branch
from
3a60fd0
to
1e27ae5
Compare
|
Why draft? :) |
| caffeinatePid=\$!; | ||
| trap \"kill -9 \$caffeinatePid\" 0 SIGINT SIGTERM; | ||
| wait {{Environment.ProcessId}}; | ||
| """.ReplaceLineEndings(replacementText: " "); |
There was a problem hiding this comment.
Can you add a comment on what is happening here?
There was a problem hiding this comment.
https://learn.microsoft.com/en-us/dotnet/api/system.string.replacelineendings says
This method searches for all newline sequences within the string and canonicalizes them to match the newline sequence for the current environment. For example, when running on Windows, all occurrences of non-Windows newline sequences will be replaced with the sequence CRLF. When running on Unix, all occurrences of non-Unix newline sequences will be replaced with a single LF character.
The idea was that raw-string literals would help us avoid fuss with escapings but it did not turn out as planned.
|
With the last commits, tACK 2022-12-07_10-05-27.mp4I propose to keep in mind the issue about |
|
edit: No, only on linux. |
|
tACK on 1cbbd57 |
|
Very well done. |
Follow-up to #9548 with better inhibitor script