Make sure we never use other than segwit script for change outputs #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molnard
reviewed
Dec 7, 2022
| @@ -140,7 +140,7 @@ public TransactionFactory(Network network, KeyManager keyManager, ICoinsView coi | |||
| } | |||
| else | |||
| { | |||
| changeHdPubKey = KeyManager.GetKeys(KeyState.Clean, true).First(); | |||
| changeHdPubKey = KeyManager.GetNextChangeKey(); | |||
There was a problem hiding this comment.
Previously it was random (depending on the order of keys in the KeyManager) as far as I can see, correct?
There was a problem hiding this comment.
No. I just added the "make sure it is segwit" part, the rest is exactly the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure to use segwit scripts for change outputs.