Fix "Bitcoin Knots doesn't work" issue #9714
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables wallet for Bitcoin Knots when starting it. The reasons are the following:
Let me elaborate on point (3):
I recently changed computers and noticed Wasabi Wallet cannot start Bitcoin Knots. It fails with the following message:
So I checked Bitcoin Knots' logs and found this to be the reason why it fails to start:
My theory is that Wasabi ships older Knots version (LTS) than what I have installed on my computer (I won't check it, don't even ask. A good programmer maximizes work not done.)
So figured if that's the case, then I should just disable the wallet and it should work. And it did. We should do this anyway as elaborated in (1) and (2).
This change should make Wasabi's full node more robust against future Bitcoin Core changes.