Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Wasabi Wallet After Install #9721

Merged
merged 2 commits into from
Dec 13, 2022
Merged

Run Wasabi Wallet After Install #9721

merged 2 commits into from
Dec 13, 2022

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Dec 9, 2022 •
edited

Fixes #4325

image

Notes

  • It would be good to actually tick the checkbox by default. Not sure how to do it at the moment.
  • The first commit shows how to run WW without any interaction whatsoever after the installation is done. This is slightly uncommon behavior though.
  • The second commit adds the checkbox and fixes Run Wasabi Wallet After Install #4325. However, the checkbox is located in a gray rectangle. That's a known WIX issue and I have not found any workaround.

Resources

@kiminuo kiminuo requested a review from yahiheb December 9, 2022 08:17
@kiminuo kiminuo marked this pull request as ready for review December 9, 2022 13:51
@kiminuo kiminuo mentioned this pull request Dec 12, 2022
Closed
@molnard
Copy link
Collaborator

molnard commented Dec 12, 2022

Awesome, the screenshot is from your test?

@kiminuo
Copy link
Collaborator Author

kiminuo commented Dec 12, 2022

Yes

yahiheb
yahiheb approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@molnard molnard merged commit 612c92f into WalletWasabi:master Dec 13, 2022
@molnard
Copy link
Collaborator

molnard commented Dec 13, 2022

GJ

@kiminuo kiminuo deleted the feature/2022-12-09-wix-start-after-install branch December 13, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run Wasabi Wallet After Install
3 participants
@kiminuo @molnard @yahiheb