Add the logic of cancelling operations if the round ends prematurely 2 #9727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiminuo
reviewed
Dec 14, 2022
| waitRoundEndedTaskCts.Cancel(); | ||
| try | ||
| { | ||
| _ = await waitRoundEndedTask.ConfigureAwait(false); |
There was a problem hiding this comment.
@molnard Why we don't do
roundState = await waitRoundEndedTask.ConfigureAwait(false);if the task can provide that value, it's "latest one can get" for that specific round, or not?
|
Post-mortem but LGTM Would be nice to have some tests for this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring #9681