Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VDG] Add confirmation count to CJ details view #9729

Merged
merged 2 commits into from
Dec 13, 2022
Merged

[VDG] Add confirmation count to CJ details view #9729

merged 2 commits into from
Dec 13, 2022

Conversation

adamPetho
Copy link
Collaborator

Fixes: #9713

Sorry, low hanging fruit 馃槄

soosr
soosr requested changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be dynamic (real-time up to date) like on the Transaction Details

@adamPetho
Copy link
Collaborator Author

It should be dynamic

It is dynamic. I just tested it on RegTest.

@soosr
Copy link
Collaborator

soosr commented Dec 9, 2022

It should be dynamic

It is dynamic. I just tested it on RegTest.

Ahh really, I forgot it calculates the confirmation from the server's Tipheight

yahiheb
yahiheb approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

MarnixCroes
MarnixCroes approved these changes Dec 9, 2022
View reviewed changes
Copy link
Collaborator

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@adamPetho adamPetho requested a review from soosr December 12, 2022 09:06
soosr
soosr approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@soosr soosr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@soosr soosr merged commit 60204cf into WalletWasabi:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soosr soosr soosr approved these changes

@yahiheb yahiheb yahiheb approved these changes

@MarnixCroes MarnixCroes MarnixCroes approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add confirmation count to Coinjoin Details
4 participants
@adamPetho @soosr @yahiheb @MarnixCroes