[VDG] Taproot UI support] #4 - Remove Remove zprv and zpub from Wallet Info #9742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ichthus1604
commented
Dec 11, 2022
ichthus1604
commented
- Title is self-explanatory
- Fixes [Taproot UI support] #4 - Remove Remove zprv and zpub from Wallet Info #9736
soosr
approved these changes
Dec 13, 2022
|
If a user loses their recovery words and they want to recover their wallet in Electrum, the only way to do that AFAIK is using the IMO this PR should be reverted. @lontivero WDYT? |
|
No @yahiheb, there is a tool on electrum that can discover your keys. Honestly I don't remember much but that's would be the way. The problem with zprv is that it is for m/84'/xxxxx + segwit only and now we have taproot too. |
|
An example of a user trying to recover with Electrum, but he couldn't. #10183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.