Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused OwnershipProof from IKeyChain #9784

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Remove unused OwnershipProof from IKeyChain #9784

merged 3 commits into from
Dec 16, 2022

Conversation

kiminuo
Copy link
Collaborator

@kiminuo kiminuo commented Dec 15, 2022 •
edited

Follow-up to the slack discussion:

Is there a reason why IKeyChain.Sign has ownershipProof parameter? Both implementations of IKeyChain:

do not seem to use the parameter.

Lucas's response:

Yes. The idea is to abstract the signer. IKeyChain tries to be that abstraction, it should be good enough to abstract smart devices that know their UTXO set as well as dumb devices that know nothing else than their keys. "Dumb" devices can be fooled to sign wrong transactions because of that. So, if one day we make coinjoins with hardware wallets or other kind of signers that have no access to the utxo/blockchain, we will need it.Currently we don't need it. We can remove it and it can be added back in the future when the time comes.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 15, 2022
@lontivero
Copy link
Collaborator

ACK

@kiminuo kiminuo marked this pull request as ready for review December 15, 2022 17:56
yahiheb
yahiheb approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@yahiheb yahiheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@molnard molnard merged commit 370431a into WalletWasabi:master Dec 16, 2022
@kiminuo kiminuo deleted the feature/2022-12-15-unused-ownership-proof branch December 16, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molnard molnard molnard approved these changes

@yahiheb yahiheb yahiheb approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kiminuo @lontivero @molnard @yahiheb