Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forwarding compile test succeeded when it should have failed #55

Closed
zkat opened this issue Sep 14, 2021 · 2 comments
Closed

forwarding compile test succeeded when it should have failed #55

zkat opened this issue Sep 14, 2021 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@zkat
Copy link
Owner

zkat commented Sep 14, 2021

I'm getting the following on cargo t:

failures:

---- src\compile_test.rs - compile_test::ForwardWithoutCode (line 113) stdout ----
Test compiled successfully, but it's marked `compile_fail`.
---- src\compile_test.rs - compile_test::ForwardWithoutCode (line 98) stdout ----
Test compiled successfully, but it's marked `compile_fail`.

failures:
    src\compile_test.rs - compile_test::ForwardWithoutCode (line 113)
    src\compile_test.rs - compile_test::ForwardWithoutCode (line 98)

@cormacrelf does this make any sense to you? Did your more recent changes make this issue moot?

@zkat zkat added bug Something isn't working help wanted Extra attention is needed labels Sep 14, 2021
@cormacrelf
Copy link
Contributor

Ah, no, that's because diagnostic(code) is now optional regardless. Those tests were written with code being mandatory in mind. You can delete 'em

@zkat
Copy link
Owner Author

zkat commented Sep 14, 2021

done. :)

@zkat zkat closed this as completed Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants