fix(finalize): don't try to cache manifests we can't get a good key for

zkat · Apr 12, 2017 · 8ab1758 · 8ab1758
1 parent b139d4b
commit 8ab1758
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/finalize-manifest.js b/lib/finalize-manifest.js
@@ -49,7 +49,8 @@ function finalizeManifest (pkg, spec, opts) {
         ? new Manifest(pkg, props)
         : new Manifest(props)
       }).then(manifest => {
-        if (!opts.cache) {
+        const cacheKey = key || finalKey(manifest, spec)
+        if (!opts.cache || !cacheKey) {
           return manifest
         } else {
           opts.metadata = {
@@ -58,7 +59,7 @@ function finalizeManifest (pkg, spec, opts) {
             type: 'finalized-manifest'
           }
           return cache.put(
-            opts.cache, key || finalKey(manifest, spec), '.', opts
+            opts.cache, cacheKey, '.', opts
           ).then(() => manifest)
         }
       })