Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VDG] Coinjoin transaction group gets collapsed by itself #10866

Open
yahiheb opened this issue Jun 9, 2023 · 7 comments
Open

[VDG] Coinjoin transaction group gets collapsed by itself #10866

yahiheb opened this issue Jun 9, 2023 · 7 comments
Labels

Comments

@yahiheb
Copy link
Collaborator

yahiheb commented Jun 9, 2023

I was looking at the transaction history list with a group of coinjoin transactions expanded then the group got collapsed by itself.
I checked the logs at that time and this is what happened around the same time:

2023-06-09 03:14:30.983 [23] INFO       MempoolService.TryPerformMempoolCleanupAsync (100)      Start cleaning out mempool...
2023-06-09 03:14:31.617 [12] INFO       MempoolService.TryPerformMempoolCleanupAsync (112)      2 transactions were removed from mempool.
@yahiheb yahiheb added the UI label Jun 9, 2023
@soosr
Copy link
Collaborator

soosr commented Jun 9, 2023

It can happen when a trigger comes to rebuild the list.

Did the scrollbar stayed in its position?

@yahiheb
Copy link
Collaborator Author

yahiheb commented Jun 9, 2023

Did the scrollbar stayed in its position?

I think yes.

It can happen when a trigger comes to rebuild the list.

Yes but it is not a good UX.

@SuperJMN
Copy link
Collaborator

SuperJMN commented Jun 16, 2023

This is normal since the history is recreated, as @soosr says. We have no means to keept track of the nodes that are expanded because they are, in fact, replaced by new nodes. Doing so can be tricky. We'd need a list of the currently expanded nodes and expand them upon rebuild.

The other option is doing it properly. But this would require a big amount of work. Tracking data as it "moves" is a difficult task. This reminds me a lot like the first version of Coin Control that was "too dynamic". I think we need something similar in the history.

The question is as always: is it worth doing this? or better, is it worth doing this now?

@Kruwed
Copy link
Collaborator

Kruwed commented Aug 13, 2023

The mempool cleaning also collapses the transaction group for CPFP as well.

@stale
Copy link

stale bot commented Oct 15, 2023

This has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@yahiheb yahiheb removed the stale label Oct 15, 2023
@Kruwed
Copy link
Collaborator

Kruwed commented Apr 17, 2024

Pockets in the wallet coins also seem to collapse by themselves as well.

@soosr
Copy link
Collaborator

soosr commented Apr 17, 2024

We are planning to make the lists dynamic, which will increase the complexity but will result in a better UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants