Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test more than MinGapLimit clean keys during resync #10904

Closed
turbolay opened this issue Jun 19, 2023 · 3 comments
Closed

Don't test more than MinGapLimit clean keys during resync #10904

turbolay opened this issue Jun 19, 2023 · 3 comments

Comments

@turbolay
Copy link
Contributor

turbolay commented Jun 19, 2023

After merge of TurboSync, there will be one last problematic case for wallet synchronization: Resyncing or recovering from file a big wallet.
It's currently a problem because when testing thousands of derived keys against the whole blockchain history, one will find hundreds of false positives blocks to download.
And it's in fact completely avoidable by taking a simple step: Never test more than MinGapLimit clean keys.

Let's say I resync from Height: 0 with a Wallet.json file containing 10.000 keys and MinGapLimit: 21.
Currently, all 10.000 keys will be tested against the whole blockchain history, which is useless: We could only test the first 21 keys , until we find a TX, then we test keys from 2 to 22, then 3 to 23..... etc...

One alternate way to do it is to "underive" the keys but store their label, then apply the labels back when sync is finished.

@turbolay
Copy link
Contributor Author

What does this assignment mean? That we want it for 2.0.7?

@MaxHillebrand
Copy link
Contributor

What does this assignment mean? That we want it for 2.0.7?

It's not in the 2.0.7 milestone, so no.

@turbolay
Copy link
Contributor Author

turbolay commented May 2, 2024

This issue is still relevant and should be fixed, however I'm closing it as it will not be worked on in a foreseeable future

@turbolay turbolay closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
@turbolay turbolay removed their assignment May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants