Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor welcome screens logic #10943

Closed
soosr opened this issue Jun 27, 2023 · 1 comment
Closed

Refactor welcome screens logic #10943

soosr opened this issue Jun 27, 2023 · 1 comment

Comments

@soosr
Copy link
Collaborator

soosr commented Jun 27, 2023

These two PRs (#10881, #10878) highlighted perfectly that the welcome screen logic is overcomplicated and very fragile.
This issue is for not forgetting to clean it up.

The main source of the problem is Carousel control which provides the transition animation. Since we are planning to have a transition animation between every view, once that is done, the control can be removed and we can simplify it. Parking until then.

@yahiheb
Copy link
Collaborator

yahiheb commented Jun 28, 2023

The two first dialogs are filled with text that doesn't add any value and many users will not read that anyway.

My very simply suggestion to improve the UX and to solve this issue is to remove those two first unneeded dialogs and to directly display the important one which is the fee dialog.

This would save us a lot of time and resources which could have been saved already when I have suggested the same over 7 months ago. #9534 (review)

@soosr soosr removed their assignment Sep 13, 2023
@soosr soosr closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants