Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPFP + Cancel Regression Tests FAIL #11557

Closed
nopara73 opened this issue Sep 23, 2023 · 4 comments · Fixed by #11575
Closed

CPFP + Cancel Regression Tests FAIL #11557

nopara73 opened this issue Sep 23, 2023 · 4 comments · Fixed by #11575
Assignees

Comments

@nopara73
Copy link
Contributor

Someone introduced bugs to CPFP + Cancel functionalities:

image
@turbolay
Copy link
Collaborator

#11507 is the PR that broke the tests.
Not sure whether or not it introduced issues on the feature

@soosr
Copy link
Collaborator

soosr commented Sep 25, 2023

Probably the CPFP transactions overpays in fees. They should be an exception where they should be allowed to do it.
I couldn't run the test on my machine to verify it:

System.AggregateException: One or more errors occurred. (Wallet file verification failed. Refusing to load database. Data file 'C:\Users\Roland\AppDat...

System.AggregateException
One or more errors occurred. (Wallet file verification failed. Refusing to load database. Data file 'C:\Users\Roland\AppData\Roaming\WalletWasabi\Tests\RegTests\BitcoinCoreData\regtest\wallet\wallet.dat' is already loaded.) (The following constructor parameters did not have matching fixture data: RegTestFixture regTestFixture)
  Exception doesn't have a stacktrace

NBitcoin.RPC.RPCException
Wallet file verification failed. Refusing to load database. Data file 'C:\Users\Roland\AppData\Roaming\WalletWasabi\Tests\RegTests\BitcoinCoreData\regtest\wallet\wallet.dat' is already loaded.
   at NBitcoin.RPC.RPCResponse.ThrowIfError()
   at NBitcoin.RPC.RPCClient.SendCommandAsync(RPCRequest request, CancellationToken cancellationToken)
   at NBitcoin.RPC.RPCClient.CreateWalletAsync(String walletNameOrPath, CreateWalletOptions options, CancellationToken cancellationToken)
   at WalletWasabi.Tests.XunitConfiguration.RegTestFixture..ctor() in WalletWasabi.Tests\XunitConfiguration\RegTestFixture.cs:line 32
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.ConstructorInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

Xunit.Sdk.TestClassException
The following constructor parameters did not have matching fixture data: RegTestFixture regTestFixture
  Exception doesn't have a stacktrace

What can I do with this?

@turbolay
Copy link
Collaborator

turbolay commented Sep 25, 2023

What can I do with this?

When I have this I kill all the dotnet / bitcoind instances running

@soosr
Copy link
Collaborator

soosr commented Sep 25, 2023

What can I do with this?

When I have this I kill all the dotnet / bitcoind instances running

killing bitcoind helped, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants