RPC recoverwallet returns error and Unknown message with Status code: OK

[wieslawsoltes]

General Description

RPC recoverwallet returns error and Unknown message with Status code: OK with invalid input data.

How To Reproduce?

RequestBody:

{"method":"recoverwallet","params":["Wallet","1",""],"jsonrpc":"2.0","id":"1"}

Status code: OK
Response body:

{"jsonrpc":"2.0","error":{"code":-32603,"message":"Unknown"},"id":"1"}

Screenshots

Operating System

Please consider your privacy, before completing this section.

Example: linuxmint 21.2

Logs

Wasabi Version

master

[lontivero]

I've been trying to find some specifications for JSON-RPC over HTTP but I couldn't find anything really concrete. There are some people suggesting some mapping between JSON-RPC error codes and HTTP status code but that's problematic for batch requests because in case you send a two-requests batch and one succeeded while the other failed, which is the real appropriated HTTP status code?

These documents seems to be two contradictory proposals:

• https://www.simple-is-better.org/json-rpc/transport_http.html
• https://www.simple-is-better.org/json-rpc/jsonrpc20-over-http.html

There is also a lot of discussions around the topic in the json-rpc specs discussion group: https://groups.google.com/g/json-rpc/search?q=http%20status%20code