Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] [MOBILE] Refactor TOR related code #11974

Open
soosr opened this issue Nov 21, 2023 · 4 comments
Open

[UI] [MOBILE] Refactor TOR related code #11974

soosr opened this issue Nov 21, 2023 · 4 comments
Labels

Comments

@soosr
Copy link
Collaborator

soosr commented Nov 21, 2023

  • Refactor code to make Tor optional (e.g. Global/TorSettings, do not include tor binaries etc.)
  • Make initializing TorSettings in Global.cs optional (as for now we do not have mobile support for running Tor)
@soosr soosr added the mobile label Nov 21, 2023
@turbolay
Copy link
Collaborator

In the meeting with Tor guys, they suggested waiting before making important changes in our Tor implementation for them to release the RPC wrapper for Arti, otherwise, we would need to handle Rust code. It changes the mobile integration, which currently has big caveats (according to them).

@Kruwed You listened to the recording more recently than when I had the meeting, so maybe you remember more details.

So we could make hacks, but not proper designing.

@wieslawsoltes
Copy link
Collaborator

In the meeting with Tor guys, they suggested waiting before making important changes in our Tor implementation for them to release the RPC wrapper for Arti, otherwise, we would need to handle Rust code. It changes the mobile integration, which currently has big caveats (according to them).

@Kruwed You listened to the recording more recently than when I had the meeting, so maybe you remember more details.

So we could make hacks, but not proper designing.

For now we just need some quick MSBuild hack to disable tor on mobile (basically not copying tor related binaries and making tor settings init optional).

@wieslawsoltes
Copy link
Collaborator

My current dirty hack in mobile PR to make it work: 7f35992

@wieslawsoltes wieslawsoltes changed the title [MOBILE] Refactor TOR related code [UI] [MOBILE] Refactor TOR related code Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants