New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add info log for randomly skipping round #12670

Closed

MarnixCroes opened this issue Mar 14, 2024 · 0 comments · Fixed by #12672

Assignees

Collaborator

MarnixCroes commented Mar 14, 2024

General Description

There is no info log in the client when it randomly skips a round

there is only a CoinJoinClientException which the user will only see in debug loglevel

https://github.com/zkSNACKs/WalletWasabi/blob/f80c24724de9885709fb52750ffd4c4ecdcdc030/WalletWasabi/WabiSabi/Client/CoinJoinClient.cs#L154

There is no way to know for a deamon user why it is not coinjoining.
Only GUI users see a musicbox message.

(should be trivial to add,
I'm not familiar with the coinjoin client code and any possible complexities and not sure how to test.)

yahiheb mentioned this issue

[Trivial] Log randomly skipping rounds #12672

Merged

molnard assigned yahiheb

turbolay closed this as completed in #12672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment