Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Terms & conditions are missing at initial wallet setup #12739

Closed
MarnixCroes opened this issue Mar 28, 2024 · 2 comments
Closed

[UI] Terms & conditions are missing at initial wallet setup #12739

MarnixCroes opened this issue Mar 28, 2024 · 2 comments

Comments

@MarnixCroes
Copy link
Collaborator

General Description

found this while debugging #12171
when starting Wasabi with an empty datadir, I go through the steps: generate a wallet... select CJ strategy and then I'm in my wallet without having accepted the Terms and Conditions.
previously the terms and conditions had to be accepted after first wallet creation, before going in to the wallet

the T&C will show up after shutting down Wasabi and then starting it with the same datadir and login to the wallet.

side note: I start Wasabi with empty datadir -> generate new wallet -> I'm in my wallet without having accepted the T&C -> generate a second wallet -> I get prompted to accept the Terms & Conditions

iirc there was a few times that I started with empty datadir and they I was prompted to accept T&C.
couldn't repro that the last few tries.

Wasabi Version

896c272 & 2.0.6

@soosr
Copy link
Collaborator

soosr commented Mar 28, 2024

It can happen that the doc is not downloaded before you finish with the wallet creation flow. Years ago we agreed that is ok to show it on the second login.

@MarnixCroes
Copy link
Collaborator Author

I see, I didn't know that.
seems like T&C show up indeed when you go slowly through the setup steps.

thought it might be introduced with the new setup flow

@MarnixCroes MarnixCroes removed the debug label Mar 28, 2024
@MaxHillebrand MaxHillebrand closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants