Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

productive_only option in filter_bcr #54

Closed
zktuong opened this issue Mar 8, 2021 · 0 comments · Fixed by #84
Closed

productive_only option in filter_bcr #54

zktuong opened this issue Mar 8, 2021 · 0 comments · Fixed by #84
Labels
need testing Extra attention is needed to work this out

Comments

@zktuong
Copy link
Owner

zktuong commented Mar 8, 2021

Currently productive_only option is toggled at the beginning of filter_contigs to restrict analysis.

However, during productive_only = False, because there's more contigs to screen against, you might end up with lesser contigs that pass the filter.

Ideally, the function should still prioritise productive contigs over non-productive contigs but right now it just keeps contigs based on UMI when productive_only = False. Perhaps a simple if-else statement might be useful to do this before comparing UMI?

However, I'm not sure what happens if there's more than 1 productive contigs of the same locus - would this impact on subsequent steps?

@zktuong zktuong added the need testing Extra attention is needed to work this out label May 13, 2021
@zktuong zktuong mentioned this issue Jul 14, 2021
2 tasks
@zktuong zktuong linked a pull request Jul 16, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need testing Extra attention is needed to work this out
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant