Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"TypeError: Cannot redefine property: push" on Chrome 113 on Mac OS X #1262

Closed
MaxHatfull opened this issue Jun 15, 2023 · 3 comments
Closed

Comments

@MaxHatfull
Copy link

Since upgrading core-js from version 3.30.2 -> 3.31.0 we've noticed the exception "TypeError: Cannot redefine property: push" coming from core-js. Our error reporting says this has only been seen on Chrome 113 on Mac OS X.

Stack trace:

File ../../../../node_modules/core-js/internals/define-built-in.js:20:31 in [anonymous]
else definePropertyModule.f(O, key, {
File ../../../../node_modules/core-js/internals/export.js:52:5 in [anonymous]
defineBuiltIn(target, key, sourceProperty, options);
File ../../../../node_modules/core-js/modules/es.array.push.js:28:1 in [anonymous]
$({ target: 'Array', proto: true, arity: 1, forced: FORCED }, {

If there's any more information we can provide, we'll try our best!

@zloirock
Copy link
Owner

zloirock commented Jun 15, 2023

Could you add a reproducible example? It looks like a broken environment where built-ins are frozen or at least Array#push made non-configurable.

3.30.2 -> 3.31.0 does not affect anything related to built-ins definition logic or Array#push polyfill.

@romainmenke
Copy link

romainmenke commented Jun 18, 2023

We see the same error :

TypeError Cannot redefine property: push 
    /node_modules/core-js/internals/define-built-in.js:20:30 e.exports
    /node_modules/core-js/internals/export.js:52:4 e.exports
    /node_modules/core-js/modules/es.array.push.js:28 8496
    webpack/bootstrap:19:31 __webpack_require__
    https://wp-static.assets.sh/ctTVRGVHRyyEofVd8tblYYB_67UuSVZVQ4QS1mcM6cc/assets/js/app.s2023-0.min.js:1:65432 
    https://wp-static.assets.sh/ctTVRGVHRyyEofVd8tblYYB_67UuSVZVQ4QS1mcM6cc/assets/js/app.s2023-0.min.js:1:113052 
    https://wp-static.assets.sh/ctTVRGVHRyyEofVd8tblYYB_67UuSVZVQ4QS1mcM6cc/assets/js/app.s2023-0.min.js:1:113056 

All seemingly coming from the same user agent string :

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36

But the number of reports is way to low to be actual Chrome 113 :

Screenshot 2023-06-18 at 23 46 22

Most we've seen is 5 error reports in a 12 hour window.
In the same window we've had ±120.000 requests, of which a certain percentage will have been for Chrome 113. This percentage will be higher than 0.0041667%

It looks like a broken environment where built-ins are frozen or at least Array#push made non-configurable.

So yeah, seems that way to us :)

@zloirock
Copy link
Owner

Closing. It seems something like a web crawler with broken js env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants