ImageValue: hashlib.md5 problems with Python 3.x

[rolexCoder]

Hello,

I'm using Python 3.5 and Dango 1.9.

When I use ImageValue i'm getting the following error:

File "/home/user/virtualenv3.5/lib/python3.5/site-packages/dbsettings/values.py", line 306, in get_db_prep_save
    hashed_name = md5(six.text_type(time.time())).hexdigest() + value.name[-4:]
TypeError: Unicode-objects must be encoded before hashing

So you can see that the problem is on file dbsettings/values.py on line 306:

hashed_name = md5(six.text_type(time.time())).hexdigest() + value.name[-4:]

CAUSE

Since Python 3.0, for hashlib.md5 you need to pass bytes instead of str. You can confirm that in Python documentation:

https://docs.python.org/2.7/library/hashlib.html
https://docs.python.org/3.0/library/hashlib.html
https://docs.python.org/3.1/library/hashlib.html
...
https://docs.python.org/3.5/library/hashlib.html

RESOLUTION

Replace line 306 with the following code:

        import sys
        PYTHON_VERSION = sys.version_info
        value_to_hash = six.text_type(time.time())
        if PYTHON_VERSION >= (3, 0):
            value_to_hash = value_to_hash.encode()
        hashed_name = md5(value_to_hash).hexdigest() + value.name[-4:]

Thanks for your great work.

[rolexCoder]

Hello,

With your last modification i'm getting an error on Python 3.5:

hashed_name = md5(six.binary_type(time.time())).hexdigest() + value.name[-4:]
TypeError: 'float' object is not iterable

Current Line 309:

        hashed_name = md5(six.binary_type(time.time())).hexdigest() + value.name[-4:]

SOLUTION

Please go back using function six.text_type() and encode the result so it is compatible with Python 3.0+.

Line 309 must be like this:

        hashed_name = md5(six.text_type(time.time()).encode()).hexdigest() + value.name[-4:]

It was tested on Python 2.7 and Python 3.5 and works great!

Regards.