Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SNI for scanners using TLS #147

Closed
justinbastress opened this issue Jul 5, 2018 · 2 comments
Closed

Fix SNI for scanners using TLS #147

justinbastress opened this issue Jul 5, 2018 · 2 comments
Assignees
@justinbastress
Labels
bug

Comments

@justinbastress
Copy link
Contributor

Currently no scanners other than the standalone TLS one expose their ScanTargets to the TLS library, so they are unable to use the target's domain name in SNI.

They should be updated to use the new APIs introduced in #146.
@justinbastress justinbastress self-assigned this Jul 5, 2018
@justinbastress justinbastress mentioned this issue Jul 5, 2018
Merged
@bvandersloot bvandersloot mentioned this issue Mar 2, 2019
Merged
@mzpqnxow
Copy link
Contributor

@justinbastress can this one be closed out?

FYI, there was a bug in the SNI handling after this, associated with redirects (see #300) but a fix was merged in #306, so SNI should be fully working now

Thank you to you and @bvandersloot for laying the groundwork for SNI

@dadrian dadrian closed this as completed Jul 31, 2021
@dadrian
Copy link
Member

dadrian commented Jul 31, 2021

I think this is fixed, if it's not, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinbastress justinbastress

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dadrian @mzpqnxow @justinbastress