apr_jwe_decrypt_content_aesgcm() null terminate string #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes unit test failure. The test test_jwt_decrypt_gcm() in test.c would sometimes fail. The failure was caused by extra garbage appearing in the decrypted string after the expected string. This is due to the failure of apr_jwe_decrypt_content_aesgcm() to null terminate the string as is similarity done in apr_jwe_decrypt_content_aescbc(). This patch copies the logic from apr_jwe_decrypt_content_aescbc() regarding the decryption output length (p_len) and the final output length (f_len) which are then used to compute the end of the data in the output buffer, the next octet after the decrypted data in the output buffer is then assigned a null terminator. Signed-off-by: John Dennis <jdennis@redhat.com>
zandbelt
pushed a commit
that referenced
this pull request
Apr 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes unit test failure.
The test test_jwt_decrypt_gcm() in test.c would sometimes fail. The
failure was caused by extra garbage appearing in the decrypted string
after the expected string. This is due to the failure of
apr_jwe_decrypt_content_aesgcm() to null terminate the string as is
similarity done in apr_jwe_decrypt_content_aescbc().
This patch copies the logic from apr_jwe_decrypt_content_aescbc()
regarding the decryption output length (p_len) and the final output
length (f_len) which are then used to compute the end of the data in
the output buffer, the next octet after the decrypted data in the
output buffer is then assigned a null terminator.
Signed-off-by: John Dennis jdennis@redhat.com