Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply cycle based debounce work to direct pin kscan #1104

Closed
Nicell opened this issue Jan 30, 2022 · 2 comments
Closed

Apply cycle based debounce work to direct pin kscan #1104

Nicell opened this issue Jan 30, 2022 · 2 comments
Labels
core Core functionality/behavior of ZMK enhancement New feature or request

Comments

@Nicell
Copy link
Member

Nicell commented Jan 30, 2022 •
edited

@joelspadin Did an amazing overhaul on the debouncing of matrix-based kscan devices in #888 using cycle-based debouncing. We should apply similar changes to the direct wire kscan driver. Also, unfortunately, the debouncing documentation doesn't apply to the direct wire kscan, so it could be a bit confusing for those using it until this is implemented.

Just realized we don't do this for the demux driver either, we should look at that as well.
@Nicell Nicell added enhancement New feature or request core Core functionality/behavior of ZMK labels Jan 30, 2022
@Nicell Nicell mentioned this issue Jan 30, 2022
Merged
11 tasks
@kurtis-lew
Copy link
Contributor

I believe #1288 addresses this issue, which has been recently merged.

@petejohanson
Copy link
Contributor

Indeed! Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Core functionality/behavior of ZMK enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@petejohanson @Nicell @kurtis-lew