-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soft off on the right side of Corne split keyboard issues #2300
Comments
On the right side there isn't any event, on the left I saw this
But when it works I saw:
My educated guess is that the left side goes down before completing the request to the right side. |
I added this to app/src/behaviors/behavior_soft_off.c
the whole fragment looks like
So far so good. I think the issue is introduced because the event is triggered when the key is released, so it's a matter of luck. |
I think this should be tweaked a bit to only add the sleep if we are specifically a split central. Does it work as expected with that in place? |
So far my hack is working, I'm giving it more time to be sure. I'll open a PR if it goes ok for a couple of days. |
This a sequel of #2274, which is partially solved in #2285
The behavior is not consistent, most of the times works perfectly, but sometimes the right side is still on.
Reporting this now, I'll update my firmware to debug and update this issue when it happens.
On the other hand I don't know where to look to use the
wakeup-source
in my config, because there are some use cases that have no reset switch.The text was updated successfully, but these errors were encountered: