Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-Native link does not work because package name does not correspond with gradle import #88

Closed
ThaJay opened this issue Dec 16, 2016 · 4 comments

Comments

@ThaJay
Copy link

ThaJay commented Dec 16, 2016

dependencies {
    compile project(':react-native-sound')
    compile fileTree(dir: "libs", include: ["*.jar"])
    compile "com.android.support:appcompat-v7:23.0.1"
    compile "com.facebook.react:react-native:+"  // From node_modules
}

sould contain

    compile project(':RNSound')

Mildly annoying as all the other ones I use get this right.

@benvium
Copy link
Collaborator

benvium commented Feb 9, 2017

PR #105 addresses this issue

@benvium
Copy link
Collaborator

benvium commented Feb 9, 2017

react-native link react-native-sound works. I've updated the manual install steps to perform the same changes the link command does.

@benvium benvium closed this as completed Feb 9, 2017
@paapii3d
Copy link

paapii3d commented Mar 7, 2018

React-native link react-native-sound only links my IOS, it doesn't link my android

/projects/hcdd$:react-native link react-native-sound
Scanning folders for symlinks in /projects/hcdd/node_modules (11ms)
rnpm-install info iOS module react-native-sound is already linked

so wen i run react-native run-android i get an error. How can i fix this? But IOS works fine

@trepidity
Copy link
Collaborator

@paapii3d what version of RNS are you running? I released 0.10.9 that should not have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants