Show client identification in notify_connect module

[oprypin]

If someone connects to ZNC as username@identifier/network, the module will now show that identifier. When the identifier is not provided, the behavior is unchanged.

[Notice] -*status- *** username@identifier detached (from 127.0.0.1)

[DarthGandalf]

May you add a test for it?
At this point we have enough infrastructure to make this easy (make test2 and test/Integration.cpp)

[oprypin]

If this module had tests, I would gladly extend them. But I have no idea how to add new ones.

[Mikaela]

Clientnotify could probably also use this change as I don't think it has identifier either.

[oprypin]

@Mikaela Interesting. This change is even more relevant to clientnotify, and the module is more relevant to me, but I wasn't aware of it!

[Mikaela]

I believe that the two modules should be merged and same with automode/autoop. They do so similar thing and better than two separate modules would be just having options "notify me (admin) when someone else connects" or "notify me when other clients login as me". But that is a separate issue.

[oprypin]

I investigated the testing facilities.
So make test2 requires sudo make install? No, thanks 😐

[DarthGandalf]

why sudo?
./configure --prefix=/tmp/znc

2015-11-27 9:44 GMT+00:00 Oleh Prypin notifications@github.com:

I investigated the testing facilities.
So make test2 requires sudo make install? No, thanks [image:
😐]

—
Reply to this email directly or view it on GitHub
#1195 (comment).

[DarthGandalf]

Oh, I've noticed you added the test...
Please comment in such cases; github doesn't notify about new commits in PR, but does about new comments.

[DarthGandalf]

Merged with this change: d736397