Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use module names as the module ident. #1874

Merged
merged 1 commit into from Sep 10, 2023
Merged

Conversation

RealKindOne
Copy link
Contributor

Some clients will reuse query windows as the client thinks its just a nick change if you have a existing query window with a module and a different one messages you.

Fix that by using the modules name as the ident.

Current format:

*status!znc@znc.in
*sasl!znc@znc.in

New format:

*status!status@znc.in
*sasl!sasl@znc.in

Client reusing query windows:

18:18:49 -!- Irssi: Starting query in Libera.Chat with *controlpanel
18:18:49 <KindOne> addnetwork
18:18:49 <*controlpanel> Usage: AddNetwork [user] network
18:21:47 -!- *controlpanel is now known as *status
18:21:47 <*status> IRC connection timed out.  Reconnecting...
18:22:06 <KindOne> disconnect
18:22:06 <*status> Disconnected from IRC. Use 'connect' to reconnect.

@DarthGandalf
Copy link
Member

Please fix tests, you can see CI broke

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1874 (ee9ad2f) into master (41032f8) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
- Coverage   43.26%   43.24%   -0.03%     
==========================================
  Files         122      122              
  Lines       32384    32388       +4     
  Branches       33       33              
==========================================
- Hits        14012    14005       -7     
- Misses      18347    18358      +11     
  Partials       25       25              
Files Changed Coverage Δ
src/Client.cpp 78.25% <100.00%> (+0.07%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41032f8...ee9ad2f. Read the comment docs.

📢 Have feedback on the report? Share it here.

Some clients will reuse query windows as the client thinks its just a
nick change if you have a existing query window with a module and a different one messages you.

Fix that by using the modules name as the ident.

Update tests to match new modules ident.
@RealKindOne
Copy link
Contributor Author

Fixed.

@DarthGandalf DarthGandalf merged commit 3779a9b into znc:master Sep 10, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants