Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++17 #1887

Merged
merged 5 commits into from Nov 19, 2023
Merged

C++17 #1887

merged 5 commits into from Nov 19, 2023

Conversation

DarthGandalf
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Merging #1887 (0a35563) into master (5e950e6) will decrease coverage by 0.03%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1887      +/-   ##
==========================================
- Coverage   43.69%   43.66%   -0.03%     
==========================================
  Files         122      121       -1     
  Lines       32408    32371      -37     
  Branches       33       33              
==========================================
- Hits        14161    14136      -25     
+ Misses      18222    18210      -12     
  Partials       25       25              
Files Coverage Δ
include/znc/Message.h 83.33% <100.00%> (ø)
src/Message.cpp 95.70% <100.00%> (ø)
include/znc/Translation.h 80.00% <80.00%> (-20.00%) ⬇️

... and 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e950e6...0a35563. Read the comment docs.

This works nicely with znc-buildmod because it will now ask cmake to
support at least C++17, but not limit modules to it
@DarthGandalf DarthGandalf merged commit c77b50d into znc:master Nov 19, 2023
14 checks passed
@DarthGandalf DarthGandalf deleted the cxx17 branch November 19, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant