Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when Dialog does not have a actions prop #31

Closed
willdurand opened this issue Feb 16, 2018 · 1 comment
Closed

Error when Dialog does not have a actions prop #31

willdurand opened this issue Feb 16, 2018 · 1 comment

Comments

@willdurand
Copy link
Contributor

According to the prop types definition, it should be possible to have a dialog without actions, but this causes an error because the Dialog tries to iterate over the actions (.map()). It should be possible to use a Dialog without actions.

@mikbry
Copy link
Contributor

mikbry commented Feb 16, 2018

You should have actions or Buttons as children or nothing right. I don't see when this error occur. In DialogFooter it iterate over an empty "a" variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants