Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TeacherTube? #53

Closed
queejie opened this issue May 13, 2019 · 4 comments
Closed

Add TeacherTube? #53

queejie opened this issue May 13, 2019 · 4 comments

Comments

@queejie
Copy link

queejie commented May 13, 2019

Thanks for this great utility! I've been trying to add TeacherTube into the library, but my abilities with regular expressions are near zero. I think it would be pretty straightforward to add for someone who has done it before. Wondering if you might consider adding it?

@Zod-
Copy link
Owner

Zod- commented May 13, 2019

Can you provide some sample URLs with possible formats?

Writing RegEx is a bit easier when you use some diagram tool.
image
image

Atom and VS Code both have the RegEx Railroad Diagram addons that show the live graph of the regex when you edit them. There are also online tools like Regexper.

@queejie
Copy link
Author

queejie commented May 14, 2019

Full page:
https://www.teachertube.com/video/les-homophones-ces-ses-la-rgle-488055

Embedded:
//www.teachertube.com/embed/video/488055

Image:
https://cdn.teachertube.com/uploads/2019/05/14/488055/fra-ortho-homophones-ces:ses-nouvelle-video000.jpg

The last one isn't going to be workable because of the datea, but there seems to be code in the Python code change that might give a clue:
ytdl-org/youtube-dl@837b061

@queejie
Copy link
Author

queejie commented May 14, 2019

Worst case, I could use this image, if there is no way to get one:
https://www.teachertube.com/frontend/themes/default/assets/images/default_video_thumb.jpg

@Zod-
Copy link
Owner

Zod- commented Jul 13, 2019

Yeah I didn't find a way to get thumbnails with just the video id.
I added support for video, audio, document, group, channel, collection and released it in 0.4.0

@Zod- Zod- closed this as completed Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants