ToxProxy AppImage generates (apparently) invalid ToxIDs

[geebotron]

Describe the bug
The output of running the ToxProxy AppImage produces a ToxID, that when pasted into TRIfA reports that the ID is invalid.

To Reproduce
Steps to reproduce the behavior:
I ran the AppImage on a Debian stable box.

Subsequently, I deleted the files the AppImage produced in the directory it lives in, and ran it again (as new) to produce a different Tox ID. This new ID was still invalid, according to TRIfA.

Expected behavior
Pasting the generated ToxID into the "Add Friend" dialog would result in the ToxProxy ID being accepted.

Your system information:

• TRIfA Version: 1.0.94
• ToxProxy Version: 0.99.4
• App from: F-Droid
• Android OS Version: 11
• Device: Sansung S10e

Add screenshots, if possible

Additional context
This may be a problem with TRIfA itself - as pasting the IDs into another Tox client seemed to accept them. They appear to be 76 chars long, and with no unusual chars ...
Strangely - deleting the last character of the generated ToxID allowed the ID to be claimed as valid in TRIfA - but it still didn't add a friend or work correctly.
Could this be a validation issue in TRIfA?

Also - Regarding firewalls:
Is it required to make firewall adjustments to allow incoming connections on the host of the AppImage for UDP on port 33445? I noticed it was listening on port 33445 so I allowed incoming cxns in the firewall rules.

Thanks

[zoff99]

Is it required to make firewall adjustments to allow incoming connections on the host of the AppImage
--> no

[zoff99]

can you post a screenshot of trifa when it says the ID is invalid?
do you have any "spaces" or other characters in front or at the end of the ToxID?
like "tox:" at start or something?

[zoff99]

just tried it again on the emulator, and it works fine.
do not copy the "ToxID:" part.

if it's still not working, please make screenshots and post more details

[geebotron]

I only capture the part after the "ToxID:" and I have pasted the same string into QTox which seemed happy.

ToxProxy version: 0.99.4
#############################################################
#############################################################

ToxID:C012744F65AC1F40F70920F808506E7E54DB943578FA55652009BB610B87F32E672F6E81F870

#############################################################
#############################################################

[zoff99]

can you scroll the text fully to the left, to show the start of the pasted ToxID please?

[geebotron]

[zoff99]

there must be something wrong with the text you copied.
if (editable.length() == (TOX_ADDRESS_SIZE * 2))
it only checks the length of the input text

[zoff99]

did you copy the final "\n" or something?
can you make sure the pasted text is TEXT only no formatting or special chars?

maybe remove the front letter and type it in manually and remove the end letter and type that in manually.
i would need to know where the problem is, to fix it.

can you join the matrix channel?

[geebotron]

Yeah. It's like there's some sort of invisible char captured. If I delete the final char of the string (or any single char) the "incorrect ToxID" message goes away.
I'm damned if I can find any additional chars - I pasted the clipboard with the ToxID into a plain text editor. Nothing unusual at the start or the end. Weird.

[geebotron]

Just joined the Matrix channel BTW ...

[zoff99]

it can only be the "\r" or "\n" when you select the line ending when you copy.
can you paste into a file and display in hex?

[zoff99]

note to self: remove any \r and \n in pasted ToxIDs (if not already done)

[zoff99]

should be fixed by e765b9b
lets close it