Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel in "axis selection" dialog #99

Closed
abetis opened this issue Aug 22, 2020 · 2 comments
Closed

Cancel in "axis selection" dialog #99

abetis opened this issue Aug 22, 2020 · 2 comments

Comments

@abetis
Copy link
Contributor

abetis commented Aug 22, 2020

When adding a part into assembly, the first dialog asks to select a part from a list, give it a name and after that another dialog opens, where I have to select the matching axis and rotate if needed.
In that dialog there are 3 buttons: OK, Cancel and Ignore.
OK is obvious and works ok.
Ignore - the new part will be added without axis selection for now, can assign them later with "Move/Attach a part in the assembly button" - that's how it works now and that's ok too.
Cancel button behaves the same as Ignore, while I would expect that the process of addition of the part will be canceled and new part will not appear in the assembly...

@Zolko-123
Copy link
Owner

the "Cancel" button serves when attaching a part, and you don't want to retain the new location: in this case, the old attachment is restored, meaning that the new attachment is cancelled. For a part that has not been attached before, there is an ambiguity, you're right.

Can you please try to attach a part that has been attached before and tell whether the Cancel button behaves as expected ?

@abetis
Copy link
Contributor Author

abetis commented Aug 23, 2020

When re-attaching a part, the cancel behavior is correct.
It's not an ambiguity, it's more like a confusion for someone who don't know how the button should behave in that case.
Here's the scenario related to another case I've opened (no needed axis appear in the selection list):
I want to add a sub-assembly part, select it from the list, get to the document that shows the attachment points (LCSs, axis), see that there is no needed attachment point listed. Want to abort... What should I do?
Cancel is the most reasonable button I would press.
Going back to the sub-assembly part I need to add the axis to, fix whatever need to be fixed (add axis, do import), get back to the main assembly, add the sub-assembly part again (since I've canceled previous operation)...
In that case I'll have 2 sub-assembly parts in the main assembly...
That's from the new user point of view. Now that I know that the operation is not really canceled, I'll go to the list and re-attach the sub-assembly, or delete the object after "canceling" the operation.

You're the owner of the repository, its your right to close the issues, but I think you close it too fast.
For me, as a new user (and a programmer with experience), the behavior doesn't looks right.
At least leave it as a minor bug, TODO, or whatever, since its not a show-stopper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants