-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RGB Styling #121
Comments
Hi, do you mean allowing individual RGB values when selecting a colour? Eg 3 inputs, one for R, one for G and one for B? |
I think he means using a spectrum of colours instead of one colour, like this. That would be a resource hog with css, I dunno about js. |
Got a verions of this working after a lot of experimenting. Will be out in the next release. |
After a lot of experimenting and testing this past week the following has been learnt:
Does not animate the same as:
Which is a damn shame because if CSS animate worked the same with variables it would have solved the performance issue perfectly. For those reasons I am considering removing this feature from nightTab. For now a warning is placed near the controls for this feature. |
This comment has been minimized.
This comment has been minimized.
I think the effect on performance is not that bad, any recent PC will handle it easily. |
That is really cool, not seen that mod before but I am familiar with the technique used to create the effect. I considered doing something similar with nightTab however this technique only works when animating a single area/background. With multple elements on the page (with the accent colour) there is no "one background". All the bookmarks, for example, need to animate at the same rate but offset to match the effect of the background moving. Since each bookmark is responsive, and can change in width, the animation, timing and syncchronisation of the backgrounds becomes nearly impossible.
Yes I agree. In my testing some machines handled it better than others. But there will always be situations, (when a system is under heavy load, lots of tabs open etc) where performance will be poor. I now agree with you, the warning added to the control should be enough. Thank you for the help 👍 |
How about that instead of choosing a solid color we can use RGB patterns.... you know more rgb = more fps
The text was updated successfully, but these errors were encountered: