Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Background file not loading. (Firefox) #69

Closed
Munkenmo opened this issue Jul 21, 2019 · 11 comments
Closed

Local Background file not loading. (Firefox) #69

Munkenmo opened this issue Jul 21, 2019 · 11 comments
Labels
bug Something isn't working investigate

Comments

@Munkenmo
Copy link

OS : Windows 10
Firefox : Version 68.0.1
NightTab : 3.61.0 (Addon)

When selecting a local background file, no background appears. Using a URL works fine. (I've also exported my backup.json to chrome, and everything works fine there.)

Attached is a copy of the error log that appears in console:

nightTab version 3.61.0 init.js:2:9
data version 3.61.0 no need to run update data.js:46:17
Error in parsing value for ‘-webkit-text-size-adjust’.  Declaration dropped. reset.css:10:29
Unrecognized at-rule or error parsing at-rule ‘@-ms-viewport’. reset.css:15:14
Unknown property ‘text-decoration-skip-ink’.  Declaration dropped. reset.css:61:28
Unknown property ‘speak’.  Declaration dropped. icons.css:16:9
Unknown property ‘-moz-osx-font-smoothing’.  Declaration dropped. icons.css:24:27
Unknown property ‘speak’.  Declaration dropped. form.css:198:9
Unknown pseudo-class or pseudo-element ‘-moz-color-swatch-wrapper’.  Ruleset ignored due to bad selector. form.css:332:21
Ruleset ignored due to bad selector. form.css:428:43
Ruleset ignored due to bad selector. form.css:434:43
Unknown property ‘user-select’.  Declaration dropped. link.css:104:15
Unknown property ‘-moz-osx-font-smoothing’.  Declaration dropped. fontawesome.css:10:27
Stylesheets without CSSOM changes reparsed to check for errors. Refresh the page to also see errors from stylesheets changed from CSSOM and from style attributes.

This log was taken after clearing the addon data and closing / reopening firefox.
I then loaded a local background file, but the error log was the same, (even after closing / reopening)
Loading a URL background also resulted in the same errors, but does display a background.

@Q-out
Copy link

Q-out commented Jul 22, 2019

For the record it only shows these errors when the CSS filter is enabled, it does not show these in the regular Error or Warning filters.
Screenshot (77)
Screenshot (78)

Also, it is loading the local background for me. But not every image will load. I've tried different resolutions, file sizes, file types, and special characters in file names.

For example these images work on my end:
https://i.imgur.com/HElqzCb.png (Filename: "12 - N5eSKPp", Size: 6.65KB 1920x1080)
https://i.imgur.com/wjS2t49.jpg (Filename: "!@#$%^&()_", Size: 161KB 2560x1707)
https://i.imgur.com/vV1D3Sy.gif (Size: 169KB 800x336) (Does animate)
These don't:
https://i.imgur.com/CnqTrts.png (Size: 795KB 1920x1200)
https://i.imgur.com/QMXZmM5.jpg (Size: 1052KB 2560x1440)

It might be the Filesize? Highest I was able to load was 665KB. Weird, because Firefox is not supposed to have a Local Storage limit.

@zombieFox
Copy link
Owner

This is interesting, thanks @Munkenmo and @Q-out for the info and details. I've not got a windows machine to test on so this is difficult for me to address.

I've got a VM sort of running and am looking into this. (for the record the background image is rendered as expected on MacOS Chrome and Firefox latest).

Bear with me as I investigate.

@zombieFox zombieFox added this to In progress in Feature Development Jul 22, 2019
@zombieFox zombieFox added bug Something isn't working investigate labels Jul 22, 2019
@Munkenmo
Copy link
Author

Munkenmo commented Jul 22, 2019

I think Q-out might be onto something with file size.

I took my normal background picture, a 4.9MB .png, opened it, used paint.net to save it as a .jpg and lowered quality until it came down to 671KB, and the lower quality version is working.

@sinankizar
Copy link

sinankizar commented Jul 28, 2019

If I want to change the background color, how can I do that?
Thanks in advance and sorry to bother the topic :)

@zombieFox
Copy link
Owner

@sinankizar nightTab is a stylised new tab page. Sorry, It does not have controls to freely change the main body background colour. This is to maintain the overall look and feel of the project and to keep colour contrast for text. And to make sure the light/dark theme system works as expected.

That being said there are a few ways to make some background colour changes:

  • Load an image of a colour using the Background options
  • Use the accent colour overlay in the Background options
  • Switch the theme to light or dark

I hope that helps.

@sinankizar
Copy link

Thanks for the fast reply. I have managed change the background color with the image that has the color of my choice. Other aspects such as dark theme works flawlessly. It is the best addon for firefox. Thanks for the efforts you put it in.

@zombieFox
Copy link
Owner

zombieFox commented Jul 30, 2019

@sinankizar Bah! I went ahead and added background colour options so if a user knows the risk, can make a custom colour change. It'll be pushed out to the extension/add on in a few days.

Screenshot 2019-07-30 at 1 26 28 pm

@sinankizar
Copy link

You’re the man! When i set an image, the tab bar and the title bar sometimes expanding unexpectedly. If i can reproduce the issue, i will post the details. Thank you so much👍🏻

@anonymous133
Copy link

anonymous133 commented Aug 18, 2019

I have also some Images that don't show when I select them as background image.

Other images from that folder work.

Here are 3 examples that don't show up as background image when selected via the file dialog:

The first one shows up when used via online source (https://i.imgur.com/VzhPD4e.png). The others I don't know.

VzhPD4e

1xcm5bsohca31

4rryxdzbktn21

@zombieFox
Copy link
Owner

Thank you @anonymous133 for more details. I'm still investigating alternative ways to load local files. This issues is a tough one.

@zombieFox
Copy link
Owner

After a lot of investigating and a few project changes, local images was dropped from the project scope. Closing this issue as I can't support this feature any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working investigate
Projects
None yet
Development

No branches or pull requests

5 participants