Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Pool interface? #74

Closed
josharian opened this issue Feb 2, 2024 · 2 comments
Closed

Add a Pool interface? #74

josharian opened this issue Feb 2, 2024 · 2 comments

Comments

@josharian
Copy link
Contributor

josharian commented Feb 2, 2024

I recently tried out package sqlitemigration and found that it meant I had to change a bunch of places that were using *sqlitex.Pool. I'd like it if there was a pre-existing interface I could pass around that covered both of them.

And/or if I could have a method on sqlitemigration.Pool that returned a *sqlitex.Pool, perhaps eagerly running the migrations (I don't really need the laziness). that would make it a lot easier to retrofit into an existing project.

@josharian
Copy link
Contributor Author

In fact...I'm not sure I understand how this is meant to be used. In particular, why is it lazy? I kind of just want to do the migrations eagerly, know they worked, and then move on.

@josharian
Copy link
Contributor Author

Oh, that's what Migrate is for. OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant