Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication protected app issue #6

Closed
MaartenG opened this issue Nov 12, 2014 · 5 comments
Closed

Authentication protected app issue #6

MaartenG opened this issue Nov 12, 2014 · 5 comments

Comments

@MaartenG
Copy link

I have an application where the root path is a page with omniauth-crowd authentication. Because of this, call_app fails with

Bad request: <html><body>You are being <a href="http://example.org/auth/crowd/">redirected</a>.</body></html>

Should it really consider a redirect a failure?
@schneems
Copy link
Member

Probably not, here's the relevant lines:

https://github.com/schneems/derailed_benchmarks/blob/master/lib/derailed_benchmarks/tasks.rb#L62

and

https://github.com/schneems/derailed_benchmarks/blob/master/lib/derailed_benchmarks/tasks.rb#L57

I added that because i was making a ton of requests to a bad URL by accident. Guess any 2xx request should be considered success. After that, we can't really assume. Maybe make it user-set-able. How does something like that sound to you?

DerailedBenchmarks.config do |config|
  config.acceptable_status_codes = [301, 302]
end

@MaartenG
Copy link
Author

That feels weirdly specific for what this gem is trying to do, maybe? Should benchmarking know about acceptable status codes? What if I could just provide some sort of environment variable like IGNORE_BAD_REQUEST=1 .

@rjocoleman rjocoleman mentioned this issue Nov 15, 2014
Closed
@schneems
Copy link
Member

Related to #10

@schneems
Copy link
Member

You can now perform some benchmarking without having to boot your app. Check the readme for more info. I still haven't addressed this specific issue. Not 100% sure the best way to move forwards

@schneems
Copy link
Member

You can test with an authenticated endpoint now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schneems @MaartenG