Improve handling of feature flags #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cargo pgx currently builds with --no-default-features along with a single postgres-version feature. This commit adds a flag allowing arbitrary additional features to be passed to the underlying cargo command.
This commit teaches 'cargo pgx' how to understand cfgs based on cargo features, so that SQL can be generated, or not, depending on what features are activated.
|
EDIT: I've taken care of this part |
|
Thanks @JLockerman! We'll take care of these, but there's two little changes before we merge:
|
Hoverbear
requested review from
Hoverbear and
eeeebbbbrrrr
and removed request for
Hoverbear and
eeeebbbbrrrr
Hoverbear
added a commit
that referenced
this pull request
May 1, 2021
`pgx` v0.1.21 is a minor feature release with the following features: * aarch64 support was added (#127) * add Nix flake (#124) * `cargo-pgx pgx init` does `initdb` (#123) * Improve handling of feature flags (#118) * Allow overriding function names and returning schema-qualified type (#117) * update dependencies (#122). * (docs) Add caveat about reconnecting after updating extension (#116) There were the following fixes: * (`cargo-pgx`) on init, lazy fetch version list (#119) To upgrade, please run: ``` $ cargo install cargo-pgx --version 0.1.21 ``` Also, make sure to update your Cargo.toml dependencies. Signed-off-by: Ana Hobden <operator@hoverbear.org>
Merged
Hoverbear
added a commit
that referenced
this pull request
May 1, 2021
`pgx` v0.1.21 is a minor feature release with the following features: * aarch64 support was added (#127) * add Nix flake (#124) * `cargo-pgx pgx init` does `initdb` (#123) * Improve handling of feature flags (#118) * Allow overriding function names and returning schema-qualified type (#117) * update dependencies (#122). * (docs) Add caveat about reconnecting after updating extension (#116) There were the following fixes: * (`cargo-pgx`) on init, lazy fetch version list (#119) To upgrade, please run: ``` $ cargo install cargo-pgx --version 0.1.21 ``` Also, make sure to update your Cargo.toml dependencies. Signed-off-by: Ana Hobden <operator@hoverbear.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables pgx to use cargo feature flags. It has two components:
--featurescommand line option to allcargo-pgxsubcommands that build code or SQL. This flag is analogous to the correspondingcargoflag: the features passed in to this flag are passed to the internal cargo commands when building the library. e.g.cargo pgx run pg13 --features foowill run"cargo" "build" "--no-default-features" "--features" "pg13 foo"#[cfg(...)]directives; it skips any object following a#[cfg(features="foo")]where the featurefooisn't passed in to the--featuresflag. (it also understandsany(...)andall(...)).The combination of these two commits allows users to enable and disable SQL functionality using cargo features.