Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route Parameters case-sensitive #58

Closed
Wulfheart opened this issue Sep 9, 2019 · 4 comments
Closed

Route Parameters case-sensitive #58

Wulfheart opened this issue Sep 9, 2019 · 4 comments

Comments

@Wulfheart
Copy link
Contributor

http://godip-adjudication.appspot.com/Classicalhttp://godip-adjudication.appspot.com/Classical works but http://godip-adjudication.appspot.com/classical doesn't.

To fix this quick and dirty assuming that every variant name is in uppercase and using string functions in the router.go via an extra function.

This might be a good first issue.

@zond
Copy link
Owner

zond commented Sep 9, 2019

http://godip-adjudication.appspot.com/ lists all variant names with the correct case. Why are you interested in making this case insensitive?

@Wulfheart
Copy link
Contributor Author

It seems odd to include spaces and cases in an URL.
However you are the maintainer and I'm bowing to your will. ;-)

@zond
Copy link
Owner

zond commented Sep 9, 2019

One compromise would be to give each variant an ID-string, guaranteed to be URL/HTML/etc-safe, and use that instead. Such a PR would be welcome :)

@zond
Copy link
Owner

zond commented May 16, 2020

Anyway, I don't think anyone would miss this issue.

@zond zond closed this as completed May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants