Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong link tag attribute in documentation #222

Closed
oscarni opened this issue Aug 23, 2019 · 1 comment · Fixed by #229
Closed

Wrong link tag attribute in documentation #222

oscarni opened this issue Aug 23, 2019 · 1 comment · Fixed by #229
Labels
bug Something isn't working documentation

Comments

@oscarni
Copy link
Contributor

oscarni commented Aug 23, 2019

Shouldn't it be href instead of src in the link-tag you add to index?
https://zonkyio.github.io/ember-web-app/docs/getting-started/installation

Now:

<link rel="manifest" src="{{rootURL}}manifest.webmanifest" />

Should be:

<link rel="manifest" href="{{rootURL}}manifest.webmanifest" />

See https://developer.mozilla.org/en-US/docs/Web/Manifest#Deploying_a_manifest_with_the_link_tag
@bobisjan
Copy link
Contributor

@oscarni thanks for report, and yes, it should be href instead.

@bobisjan bobisjan added bug Something isn't working documentation labels Aug 27, 2019
@bobisjan bobisjan mentioned this issue Sep 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use href attribute in documentation zonkyio/ember-web-app
2 participants
@bobisjan @oscarni