Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated 'use Bitwise' #168

Merged
merged 1 commit into from Jan 2, 2023
Merged

Fix deprecated 'use Bitwise' #168

merged 1 commit into from Jan 2, 2023

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Jan 2, 2023

No description provided.

@dvic
Copy link
Contributor Author

dvic commented Jan 2, 2023

See https://github.com/elixir-lang/elixir/blob/v1.14/CHANGELOG.md#4-hard-deprecations

@dvic
Copy link
Contributor Author

dvic commented Jan 2, 2023

(in lib/mongo.ex it was unused, so I removed it)

@zookzook
Copy link
Owner

zookzook commented Jan 2, 2023

Thanks for the PR. What about older Elixir versions? What is the minimal version of Elixir that would work with the changes?

@dvic
Copy link
Contributor Author

dvic commented Jan 2, 2023

I think it's fully backwards compatible, the old logic was:

https://github.com/elixir-lang/elixir/blob/0909940b04a3e22c9ea4fedafa2aac349717011c/lib/elixir/lib/bitwise.ex#L26-L42

So I guess this goes from import Bitwise, except: [] to import Bitwise

@zookzook zookzook merged commit a980d57 into zookzook:master Jan 2, 2023
@zookzook
Copy link
Owner

zookzook commented Jan 2, 2023

Thank you!

@github-actions github-actions bot mentioned this pull request Jan 2, 2023
Merged
@dvic dvic deleted the fix-bitwise branch January 2, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvic @zookzook