Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary request load on talk pages #2203

Closed
parrish opened this issue Feb 12, 2016 · 4 comments · Fixed by zooniverse/json-api-client#26
Closed

Unnecessary request load on talk pages #2203

parrish opened this issue Feb 12, 2016 · 4 comments · Fixed by zooniverse/json-api-client#26
Labels
bug talk

Comments

@parrish
Copy link
Contributor

parrish commented Feb 12, 2016

I'm not sure when this changed, but it looks like we're spamming the APIs with a ton of duplicated requests.

With a staging discussion as an example: /talk/20/37?page=3

The request load for the page looks like:

POST https://panoptes-staging.zooniverse.org/oauth/token
GET https://talk-staging.zooniverse.org/boards/20
GET https://talk-staging.zooniverse.org/discussions?id=37&sort_linked_comments=created_at
GET https://talk-staging.zooniverse.org/tags/popular?section=zooniverse&limit=20&page_size=20
GET https://notifications-staging.zooniverse.org/active_users?channel=zooniverse
GET https://panoptes-staging.zooniverse.org/api/proje...nch_approved=true&cards=true&page=1&page_size=20
GET https://talk-staging.zooniverse.org/boards/20
GET https://talk-staging.zooniverse.org/tags/popular?section=zooniverse&limit=20&page_size=20
GET https://panoptes-staging.zooniverse.org/api/users?id=27
GET https://panoptes-staging.zooniverse.org/api/proje...nch_approved=true&cards=true&page=2&page_size=20
GET https://talk-staging.zooniverse.org/tags/popular?section=zooniverse&limit=20&page_size=20
GET https://talk-staging.zooniverse.org/boards/20
GET https://talk-staging.zooniverse.org/comments?discussion_id=37&page_size=20&page=3
GET https://talk-staging.zooniverse.org/tags/popular?section=zooniverse&limit=20&page_size=20
GET https://talk-staging.zooniverse.org/comments?discussion_id=37&page_size=20&page=3
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/subjects/6892
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/subjects/3151
GET https://panoptes-staging.zooniverse.org/api/users?id=1745
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=1745
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=288433
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=288433
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=288433
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=288433
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=27
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://talk-staging.zooniverse.org/tags/popular?section=zooniverse&limit=20&page_size=20
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/subjects/6892
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/subjects/3151
GET https://panoptes-staging.zooniverse.org/api/users?id=1745
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=1745
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=288433
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=288433
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=288433
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=288433
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=96
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://panoptes-staging.zooniverse.org/api/users?id=27
GET https://talk-staging.zooniverse.org/roles?user_id...niverse%2Czooniverse&is_shown=true&page_size=100
GET https://talk-staging.zooniverse.org/tags/popular?section=zooniverse&limit=20&page_size=20
GET https://panoptes-staging.zooniverse.org/api/users/27/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/1745/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/1745/avatar
GET https://panoptes-staging.zooniverse.org/api/users/1745/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/288433/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://panoptes-staging.zooniverse.org/api/users/96/avatar
GET https://notifications-staging.zooniverse.org/active_users?channel=zooniverse
@parrish
Copy link
Contributor Author

parrish commented Feb 12, 2016

Yeah, I've tracked this regression down to the new external panoptes-client: #2113

@brian-c, Any idea why that would cause this?

@brian-c
Copy link
Contributor

brian-c commented Feb 12, 2016

Gross. I'm guessing the duplicate-GETs catcher is failing. I'll look into it right now.

(The duplicate-GETs catcher was implemented to avoid the React components having to store resources in their own state. This was a mistake in hindsight, and has lead to a lot of poorly designed components.)

@brian-c brian-c mentioned this issue Feb 12, 2016
Merged
@brian-c
Copy link
Contributor

brian-c commented Feb 12, 2016

Fixed in that json-api-client PR. Will bump that version and the panoptes-client version to match, then it should be in here. Sorry about all that.

@parrish
Copy link
Contributor Author

parrish commented Feb 12, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug talk
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make one GET request per endpoint at a time zooniverse/json-api-client
2 participants
@parrish @brian-c