Disable Deep Munging in Rails #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes zooniverse#743 Because most users of Rails are apparently unable or unwilling to check params before passing arguments to AR#find, Rails converts empty arrays in params to nil. This makes 0 sense to me, but whatever, it's easy to turn off.
|
Yeah - i'm happy to turn this off for the moment. Looks like rails/rails#13420 should end up sorting where an emprty |
|
I'm not holding my breath since that issue was opened in 2013. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #743
Because most users of Rails are apparently unable or unwilling to check
params before passing arguments to AR#find, Rails converts empty arrays
in params to nil. This makes 0 sense to me, but whatever, it's easy to
turn off.