Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message slack #3069

Merged
merged 2 commits into from Feb 7, 2019

Conversation

@marten
Copy link
Contributor

commented Feb 7, 2019

This will message slack in the following cases:

  • production webserver AMI builds successfully

  • production webserver AMI build failure

  • production dumpworker AMI builds successfully

  • production dumpworker AMI build failure

  • staging webserver AMI build failure

  • staging dumpworker AMI build failure

  • staging migration failure

  • staging deploy failure

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.
@marten marten requested a review from camallen Feb 7, 2019
Copy link
Member

left a comment

LGTM

@marten marten merged commit ea0af16 into master Feb 7, 2019
5 of 6 checks passed
5 of 6 checks passed
Label when approved Label when approved
Details
Hound No violations found. Woof!
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@marten marten deleted the jenkins-slack branch Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.