Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Subject: VideoContoller missing unit tests, storybook, and Readme documentation #3612

Closed
goplayoutside3 opened this issue Sep 6, 2022 · 1 comment
Assignees
Labels
documentation Add the documentation for something storybook Related to storybook component stories tests Related to unit tests, integration tests, etc video subject Issue related to the video subject viewer

Comments

@goplayoutside3
Copy link
Contributor

Package

lib-classifier

Describe the problem and solution

  • The features of VideoController are not documented in its Readme file. Similar to other components in lib-classifier, the basic functionality should be described in its Readme.
  • VideoController and its components do not have any unit tests. This is an opportunity to add tests with React Testing Library rather than enzyme.
  • VideoController and its components do not have any storybook stories.

Additional context

This issue documentation is sorted into the Video Annotator project board. It's part of an effort to improve the video subject viewer code for migrating Woodpecker Cavity Cam to FEM.

@goplayoutside3 goplayoutside3 added documentation Add the documentation for something storybook Related to storybook component stories tests Related to unit tests, integration tests, etc labels Sep 6, 2022
@goplayoutside3 goplayoutside3 added the video subject Issue related to the video subject viewer label Sep 6, 2022
@goplayoutside3 goplayoutside3 self-assigned this Sep 9, 2022
@goplayoutside3
Copy link
Contributor Author

Noting that scrubbing the video controller is not as smooth as PFE. I'll investigate if the UX can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Add the documentation for something storybook Related to storybook component stories tests Related to unit tests, integration tests, etc video subject Issue related to the video subject viewer
Development

No branches or pull requests

1 participant