Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to navigate to a specific workflow? Query param, or URL? #806

Closed
rogerhutchings opened this issue May 8, 2019 · 6 comments
Closed
Assignees
Labels
discussion Talk about how to do something
Projects

Comments

@rogerhutchings
Copy link
Contributor

Currently, PFE derives the workflow from the URL query parameter. We've been talking about moving to a regular URL, something like /owner/project/classify/workflow/[workflow_id] instead.

I prefer the latter - it's a static resource, which is what a URL is for.

We should to make a decision on this, since it has deployment implications for TESS.

cc @srallen @camallen @eatyourgreens

@rogerhutchings rogerhutchings added the discussion Talk about how to do something label May 8, 2019
@rogerhutchings rogerhutchings added this to To do in Classifier via automation May 8, 2019
@rogerhutchings rogerhutchings added this to the TESS Production Launch milestone May 8, 2019
@srallen
Copy link
Contributor

srallen commented May 8, 2019

I don't think we need to do this for TESS because they only need one active workflow and the new one will be set as the default workflow. We'll still need to support workflow selection if a user hits a /classify route without the workflow specified, unless we're deciding now to no longer support that? We've discussed also moving to a paradigm to prompt and ask a user what to load if the result is error, not found, etc, so we could do that if only the /classify route is navigated to, but again, I don't think this is necessary now unless we find there are issues during the production test.

As an aside, moving to a regular URL means we can also cleanly support subject set selection this way too, /classify/workflow/:workflow-id/subject-set/:subject-set-id

@rogerhutchings
Copy link
Contributor Author

/classify could redirect to the default workflow?

@eatyourgreens
Copy link
Contributor

I like the idea of redirecting so that volunteers can bookmark a specific workflow. This probably ties into our discussion the other day about how to deal with completed workflows too. The URLs should still work but maybe the classifier changes to indicate that the workflow is complete.

@srallen
Copy link
Contributor

srallen commented May 8, 2019

The redirect could trickle down the selection priorities we have: UPP (if signed in), default, random active. If none work, then prompt the user with a 404 and ask them what to do by showing the available options for the current project or prompt to try another project.

@rogerhutchings rogerhutchings removed this from the TESS Production Launch milestone May 14, 2019
@srallen
Copy link
Contributor

srallen commented May 24, 2019

CSSI CitSci has a use case to allow volunteers to be able to load a specific subject by url to classify, so I think we can plan on supporting this similarly: /classify/workflow/:workflow-id/subject-set/:subject-set-id/subject/:subject-id

@rogerhutchings rogerhutchings mentioned this issue Sep 4, 2019
7 tasks
@rogerhutchings
Copy link
Contributor Author

Following the discussion in #1077 (comment), we need to ADR this up first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Talk about how to do something
Projects
Classifier
  
Done
Development

No branches or pull requests

3 participants