Remove react fc + pnpm7 #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poteirard
requested review from
moshie,
katebeavis,
raff-r and
admmasters
as code owners
poteirard
commented
Jul 8, 2022
Comment on lines
+43
to
+44
| FC: 'See: https://fettblog.eu/typescript-react-why-i-dont-use-react-fc/', | ||
| 'React.FC': 'See: https://fettblog.eu/typescript-react-why-i-dont-use-react-fc/', |
There was a problem hiding this comment.
An interesting piece of code
poteirard
commented
Jul 8, 2022
| @@ -18,7 +18,7 @@ | |||
| "downlevelIteration": true, | |||
| "noFallthroughCasesInSwitch": true, | |||
| "types": ["node", "jest", "@testing-library/jest-dom"], | |||
| "incremental": true, | |||
| "incremental": false, | |||
There was a problem hiding this comment.
This is set to true as it had false positive with typechecking.
poteirard
commented
Jul 8, 2022
Comment on lines
-9
to
+10
|
|
||
| const ProductTemplate: ProductTemplateStatic & React.FC<ProductTemplateProps> = (props) => ( | ||
| <ProductTemplateComponent {...props} /> | ||
| const ProductTemplate = ({ children, ...rest }: ProductTemplateProps) => ( | ||
| <ProductTemplateComponent {...rest}>{children}</ProductTemplateComponent> | ||
| ); | ||
|
|
||
| ProductTemplate.Card = ProductTemplateCard; | ||
|
|
||
| export default ProductTemplate; | ||
| export default Object.assign(ProductTemplate, { Card: ProductTemplateCard }); |
There was a problem hiding this comment.
Another interesting piece of code
poteirard
force-pushed
the
remove_react_fc
branch
from
38b22c0
to
7950e81
Compare
poteirard
force-pushed
the
remove_react_fc
branch
from
7950e81
to
ca9efee
Compare
✅ Deploy Preview for zrc ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
admmasters
reviewed
Jul 9, 2022
Yes, the namespace refactor is to avoid FC. Pnpm change is in a single commit and the eslint imports as well |
poteirard
force-pushed
the
remove_react_fc
branch
from
9693676
to
a13458e
Compare
admmasters
previously approved these changes
Jul 26, 2022
moshie
previously approved these changes
Jul 26, 2022
moshie
approved these changes
Jul 26, 2022
|
🎉 This PR is included in version 5.33.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React.FCFix #763